Remove `source` and `comment` from OpenAPI models except Commit

Description

See for story. We’ll want to modify any server-side processing for these fields to match what’s in the spec.

Activity

Show:
Doris Lam
April 16, 2020, 12:20 AM

wait, we do need it in ElementsRequest, NotebooksRequest and Commit (unless you mean CommitsRequest but that’s already taken out there). there’s no way for a user to post a commit directly and they’re not supposed to be in Element(Json) when posted

Doris Lam
April 16, 2020, 12:23 AM

just to clarify, the server is taking comment and source from ElementsRequest and NotebooksRequest and setting them as the source and comment in Commit

Ivan Gomes
April 16, 2020, 12:26 AM
Edited

Is there a general way of handling that, e.g. all additionalProperties (or those nested in a field), are applied to the resulting Commit? In other words, what happens to fields that are not source and comment when using ElementsRequest to create a Commit?

Doris Lam
April 16, 2020, 12:28 AM

there’s no other fields allowed in Requests besides those specified (requests don’t have additional properties)

Ivan Gomes
April 16, 2020, 12:31 AM

That sounds like special handling of source and comment in the case of ElementsRequest, NotebooksRequest, and Commit. For the scope of this issue, I think we should spec it as-implemented.

Assignee

Doris Lam

Reporter

Ivan Gomes

Labels

None

Epic Link

Sprint

None

Priority

Medium
Configure